Added sonarcloud scanner #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if verify { | ||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://"+resMatch+"@sonarcloud.io/api/users/search", nil) |
There was a problem hiding this comment.
It looks like there's a validation endpoint: https://sonarcloud.io/web_api/api/authentication?deprecated=false
There was a problem hiding this comment.
Is the credential that we are testing with as-is from sonarcloud? I'm asking because most have to be base64 encoded before they can be used with basic auth.
There was a problem hiding this comment.
Yes, the credential is generated in sonarcloud. It is located under My Account->Security. I just updated the endpoint and added organization as parameter since it seems validation endpoint still returns true even without token or credentials.
bill-rich
pushed a commit
that referenced
this pull request
May 2, 2022
* added new protos * added sonarcloud scanner * Updated sonarcloud scanner * updated sonarcloud endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.