Feature/salesmate detector #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/detectors/salesmate/salesmate.go
Outdated
|
|
||
| //Make sure that your group is surrounded in boundry characters such as below to reduce false positives | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"salesmate"}) + `\b([0-9Aa-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})\b`) | ||
| domainPat = regexp.MustCompile(detectors.PrefixRegex([]string{"salesmateDomain"}) + `\b([a-z0-9A-Z._]{4,22})\b`) |
There was a problem hiding this comment.
suggestion: salesmateDomain is unlikely to be found, recommended to just use salesmate. After some testing, they allow a minimum of 3 characters and not working with special characters like _ or . Maybe we can go with \b([a-z0-9A-Z]{3,22})\b?
pkg/detectors/salesmate/salesmate.go
Outdated
| } | ||
|
|
||
| req.Header.Add("Content-Type", "application/json") | ||
| req.Header.Add("sessionToken", fmt.Sprintf("%s", resMatch)) |
There was a problem hiding this comment.
nit: Prefer removal of fmt.Sprintf here: req.Header.Add("sessionToken", resMatch)
| } | ||
|
|
||
| if verify { | ||
| url := fmt.Sprintf("https://%s.salesmate.io/apis/v3/companies/1?trackingRecentSearch=true",resIdMatch) |
There was a problem hiding this comment.
note: based on the docs, hardcoded id 1 here ...companies/1?... returns the current registered user/customer.
dustin-decker
approved these changes
Aug 25, 2022
javajawa
added a commit
to mewbotorg/mewbot
that referenced
this pull request
Sep 2, 2022
Add Honeycomb detector by @MNThomson in trufflesecurity/trufflehog#687 Feature/scalr detector by @lonmarsDev in trufflesecurity/trufflehog#519 added websitepulse detector by @lonmarsDev in trufflesecurity/trufflehog#516 added tokeet detector by @lonmarsDev in trufflesecurity/trufflehog#515 Feature/salesmate detector by @lonmarsDev in trufflesecurity/trufflehog#514 added kanbantool detector by @lonmarsDev in trufflesecurity/trufflehog#513 added demio detector by @lonmarsDev in trufflesecurity/trufflehog#512 added heatmapapi detector by @lonmarsDev in trufflesecurity/trufflehog#509 added getresponse detector by @lonmarsDev in trufflesecurity/trufflehog#506 added codeclimate detector by @lonmarsDev in trufflesecurity/trufflehog#484 added flightlabs detector by @ladybug0125 in trufflesecurity/trufflehog#475 added prodpad detector by @lonmarsDev in trufflesecurity/trufflehog#470 added lemlist detector by @lonmarsDev in trufflesecurity/trufflehog#469 added formsite detector by @lonmarsDev in trufflesecurity/trufflehog#467 added docparser detector by @lonmarsDev in trufflesecurity/trufflehog#458 added parseur detector by @lonmarsDev in trufflesecurity/trufflehog#454 Added ecostruxureit detector by @roxanne-tampus in trufflesecurity/trufflehog#555 Added transferwise detector by @roxanne-tampus in trufflesecurity/trufflehog#558 Added holistic detector by @roxanne-tampus in trufflesecurity/trufflehog#556 Added twist detector by @roxanne-tampus in trufflesecurity/trufflehog#549 Added monkeylearn detector by @roxanne-tampus in trufflesecurity/trufflehog#553 Added gtmetrix detector by @roxanne-tampus in trufflesecurity/trufflehog#554 Added duply detector by @roxanne-tampus in trufflesecurity/trufflehog#552 Added braintreepayments detector by @roxanne-tampus in trufflesecurity/trufflehog#541 added apilayer scanner by @lonmarsDev in trufflesecurity/trufflehog#368 added appointed scanner by @lonmarsDev in trufflesecurity/trufflehog#425 [bug] - Fix the starting index value for plus line check. by @ahrav in trufflesecurity/trufflehog#734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.