Properly count the number of repos after a github scan resume #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trufflesteeeve
requested review from
bill-rich,
mcastorina,
dustin-decker and
ahrav
mcastorina
approved these changes
Jun 16, 2022
| @@ -790,7 +790,7 @@ func (s *Source) normalizeRepos(ctx context.Context, apiClient *github.Client) { | |||
| } | |||
|
|
|||
| // setProgressCompleteWithRepo calls the s.SetProgressComplete after safely setting up the encoded resume info string. | |||
| func (s *Source) setProgressCompleteWithRepo(index int, repoURL string) { | |||
| func (s *Source) setProgressCompleteWithRepo(index int, offset int, repoURL string) { | |||
There was a problem hiding this comment.
Suggestion (optional): Same suggestion as the gitlab PR, it would be nice to have a test to prevent regressions.
trufflesteeeve
force-pushed
the
fix-github-progress-count
branch
from
d135c77
to
29769af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of repos was inaccurately reported when a scan was resumed. This fixes that. The fix is also already included in the gitlab resume PR.