Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding detector for Nvidia NGC #797

Merged
merged 9 commits into from Sep 20, 2022
Merged

Adding detector for Nvidia NGC #797

merged 9 commits into from Sep 20, 2022

Conversation

JosephTLucas
Copy link
Contributor

Reference: #790

@JosephTLucas JosephTLucas requested a review from a team as a code owner September 13, 2022 23:21
@CLAassistant
Copy link

CLAassistant commented Sep 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

ahrav
ahrav approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the contribution 😄

pkg/detectors/ngc/ngc.go Outdated Show resolved Hide resolved
@JosephTLucas
Copy link
Contributor Author

Hey @ahrav , I'm not bumping this in priority, but I want to understand the path from here. Is it just as simple as you merge whenever you're ready? Or is there more involved with transitioning the test secrets to a trufflehog-owned secrets manager + anything else?

@ahrav
Copy link
Collaborator

ahrav commented Sep 20, 2022

Hey @ahrav , I'm not bumping this in priority, but I want to understand the path from here. Is it just as simple as you merge whenever you're ready? Or is there more involved with transitioning the test secrets to a trufflehog-owned secrets manager + anything else?

My apologies I completely missed this one. We actually do not need to transition the secrets on our end. So long as the tests had passed during your run that is sufficient for us.

I think there might've been new detectors added recently which is why there looks to be a merge conflict. Once that is resolved feel free to merge this one in.

Again apologies for the delayed response here.

@ahrav ahrav merged commit b02cf7e into trufflesecurity:main Sep 20, 2022
@JosephTLucas JosephTLucas deleted the detector_ngc branch September 20, 2022 17:47
@adawalli
Copy link

This is awesome - thank you @JosephTLucas !!!

@imsatasia
Copy link

Thank you @JosephTLucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JosephTLucas @CLAassistant @ahrav @adawalli @imsatasia