Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Drizzle cache does not clear error message #192

Closed
rawfalafel opened this issue Mar 8, 2019 · 3 comments · Fixed by #196
Closed

Drizzle cache does not clear error message #192

rawfalafel opened this issue Mar 8, 2019 · 3 comments · Fixed by #196

Comments

@rawfalafel
Copy link
Contributor

Steps to reproduce:

  1. Call cacheCall on a contract method that reverts
  2. Wait until drizzleState contains error message in cache
  3. Update contract state so that the method doesn't revert
  4. Let cacheCall execute again. This time no revert.

Expected: cache doesn't contain contain error message
Actual: cache contains error message

Here's my fix which also handles the inverse case (clearing value when a method suddenly reverts): UMAprotocol/drizzle@4581c3d

@cds-amal
Copy link
Member

Thanks @rawfalafel! Can you submit a PR?

@stale
Copy link

stale bot commented May 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 14, 2019
@rawfalafel
Copy link
Contributor Author

Bump. I opened a PR for this issue that hasn’t been addressed. Thanks :)

@stale stale bot removed the wontfix label May 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants