Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

implement cleanupDirectory function #3662

Closed
MicaiahReid opened this issue Sep 15, 2022 · 2 comments
Closed

implement cleanupDirectory function #3662

MicaiahReid opened this issue Sep 15, 2022 · 2 comments

Comments

@MicaiahReid
Copy link
Contributor

When a database is instantiated, the current function to cleanup the database directory is a no-op. We should fix that.

ganache/src/chains/ethereum/ethereum/src/database.ts

Line 19 in 9980cb5

#cleanupDirectory = noop;

@davidmurdoch
Copy link
Member

Not always:

ganache/src/chains/ethereum/ethereum/src/database.ts

Line 66 in 9980cb5

this.#cleanupDirectory = dirInfo.cleanup;

@MicaiahReid
Copy link
Contributor Author

🤦‍♂️ my miss!

@paradisebee paradisebee mentioned this issue Dec 26, 2022
Open
@paradisebee paradisebee mentioned this issue Dec 6, 2023
Open
@PinkDiamond1 PinkDiamond1 mentioned this issue Dec 6, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidmurdoch @MicaiahReid