This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Include hex-encoded operands in the debug logging of opcodes. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nejucomo thanks for this excellent contribution, and sorry it took me so long to get 'round to reviewing it! I'm not sure that it needs a test to be added for this functionality, per se, but if you'd like to add one, you can see plenty of example tests in the |
Deploying with
|
| Latest commit: |
ca2965e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2459afa6.ganache.pages.dev |
| Branch Preview URL: | https://develop.ganache.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows deeper diagnosis of low-level EVM issues when using testrpc by displaying the operands for each opcode in debug mode.
How is
ganache-coretested, and how can I add test coverage for my changes? Also, does this follow any coding conventions for this project?