fix: improve account locking #1513
Conversation
User-supplied passphrase is now used to encrypt wallet. If no passphrase is supplied and the `--lock` options is not specified, initial accounts are not encrypted to improve startup speeds. A keyfile record is now added for every account. Previously, this wasn't done, making it impossible to actually unlock initial accounts. This fixes #996. Updates api with the above changes to the wallet.
Removes eth_unlockUnknownAccount and eth_lockUnknownAccount. Adds eth_addAccount and eth_removeAccount.
davidmurdoch
changed the title
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
…/ganache into fix/improve-account-locking
MicaiahReid
force-pushed
the
fix/improve-account-locking
branch
from
c3b0c83
to
05d43c8
Compare
There was a problem hiding this comment.
Left some standalone comments and suggestions.
I wonder if we should revert the changes to docs, since the release process creates them automatically. I'm thinking docs should represent the released version of ganache only? At least until we get stable out, and then we may want to host and track multiple docs versions at a time (7.0.0, 7.0.1, 7.0.2-alpha.0, 7.0.2-nightly.4, etc). Thoughts?
Also can you revert the changes to the package-lock.json and npm-shrinkwrap.json files, as I have a PR out that reverts the change that causes them to be wrong in the first place, and I should probably add these lock file changes to that PR.
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
I've reverted |
Closes #1490 and #996
--secureto--lock, keeping--secureas legacy alias.wallet.passphraseoption.evm_addAccountevm_removeAccountevm_unlockUnknownAccountandevm_lockUnknownAccount--lockand--passphraseare not specified.