fix: use `host` param when passed in `server.listen` #2397

davidmurdoch · 2022-02-17T23:50:57Z

MicaiahReid

Cool tests! But it looks like they're only passing on Ubuntu :(

davidmurdoch · 2022-03-02T02:24:31Z

src/packages/core/tests/server.test.ts

+          // on windows the zone_id is the scopeid
+          return `${info.address}%${info.scopeid}`;
+        } else {
+          // on *nix the zone_id is the `interfaceName`


this is why we can't have nice things

cds-amal

Interesting! I think these tests are more sound than the previous ones. Nice work on OSX interface filtering. I wonder what's going on with Windows networking 🤔

src/packages/core/src/server.ts

src/packages/core/tests/server.test.ts

davidmurdoch · 2022-03-02T22:19:48Z

Waiting for merge this one until after #2503 so I can stop playing the Restart All Tests game.

davidmurdoch requested a review from MicaiahReid February 17, 2022 23:50

MicaiahReid approved these changes Feb 18, 2022

View reviewed changes

davidmurdoch requested a review from cds-amal March 2, 2022 02:22

davidmurdoch commented Mar 2, 2022

View reviewed changes

cds-amal reviewed Mar 2, 2022

View reviewed changes

src/packages/core/src/server.ts Outdated Show resolved Hide resolved

src/packages/core/tests/server.test.ts Show resolved Hide resolved

davidmurdoch changed the base branch from develop to alpha March 4, 2022 18:21

davidmurdoch changed the base branch from alpha to develop March 4, 2022 18:21

davidmurdoch force-pushed the fix-host branch from f8f3830 to 164406f Compare March 4, 2022 18:36

davidmurdoch added 3 commits March 4, 2022 13:41

add server host tests

9ab51d7

update to the latest uws fork

8ae3ca7

fix: use the host param on server.listen

81bb15d

davidmurdoch force-pushed the fix-host branch from 164406f to 81bb15d Compare March 4, 2022 18:45

davidmurdoch merged commit 4f3af10 into develop Mar 4, 2022

davidmurdoch deleted the fix-host branch March 4, 2022 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use `host` param when passed in `server.listen` #2397

fix: use `host` param when passed in `server.listen` #2397

davidmurdoch commented Feb 17, 2022

MicaiahReid left a comment

davidmurdoch Mar 2, 2022

cds-amal left a comment

davidmurdoch commented Mar 2, 2022

fix: use host param when passed in server.listen #2397

fix: use host param when passed in server.listen #2397

Conversation

davidmurdoch commented Feb 17, 2022

MicaiahReid left a comment

Choose a reason for hiding this comment

davidmurdoch Mar 2, 2022

Choose a reason for hiding this comment

cds-amal left a comment

Choose a reason for hiding this comment

davidmurdoch commented Mar 2, 2022

fix: use `host` param when passed in `server.listen` #2397

fix: use `host` param when passed in `server.listen` #2397