This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Refactored gas tests #289

Merged

davidmurdoch merged 53 commits into develop from refactored-gas-test-history

Feb 13, 2019

Contributor

ccowell commented Jan 28, 2019

Added missing documentation to bootstrap module
Refactored and grouped gas related tests
Fixed reference errors to old helper files
Fixed a couple of module export definitions

ccowell added 7 commits

January 28, 2019 11:08


          Moving gas test into subdirectory

ceb1b1a


          Moved helper functions into gas lib directory

4d577f0

Refactored gasLimit, gasPrices, gas, custom_gas_limit, custom_gas_price.


          Moving gas solidity file into contract gas directory

17013e6


          Extracted rpc and sleep to individual files

b5da9c4

Updated bootstrap and compileAndDeploy module


          Removed utils.js in favor of extracting functionality into files

f564220

Added getWeb3
Added preloadWeb3 (get web3 with mocha support)


          Fixed broken reference to relocated helper files and/or contract

6c994d3


          Documented setUp module

29817fa

ccowell changed the title ~~Refactored gas test~~ Refactored gas tests

ccowell requested a review from davidmurdoch

January 28, 2019 21:53

benjamincburns reviewed

View reviewed changes

test/call.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/call/undefined.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/custom_gas_price.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/custom_gas_price.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/gasLimit.js Outdated Show resolved Hide resolved

Contributor

benjamincburns commented Jan 28, 2019

So many of these tests are validating that an option was properly handled/observed. Given that this is mostly following a pattern of "set option to nondefault value then validate that the option was set", I wonder if this couldn't/shouldn't be handled by a test helper. That way we could have a single "it observes gas options" test which just runs through a list of options

benjamincburns reviewed

View reviewed changes

test/gas/lib/customContractDeploy.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/lib/isGasExpenseCorrect.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/lib/isGasExpenseCorrect.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/lib/isGasExpenseCorrect.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/lib/toBytes.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/lib/transactionEstimate.js Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/helpers/contract/bootstrap.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/helpers/contract/bootstrap.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/helpers/web3/getWeb3.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/helpers/web3/getWeb3.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/gas/gasLimit.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/helpers/web3/preloadWeb3.js Outdated Show resolved Hide resolved

benjamincburns reviewed

View reviewed changes

test/transaction_rejection.js Outdated Show resolved Hide resolved

benjamincburns previously requested changes

View reviewed changes

Contributor

benjamincburns left a comment •

edited

From a high level this looks like a step in the right direction, but I'm a bit confused by some things (see inline comments).

As mentioned in Slack, please don't delete this PR, just submit changes to the same branch so we can preserve the comment history.

benjamincburns reviewed

View reviewed changes

test/gas/gas.js Outdated Show resolved Hide resolved

ccowell added 2 commits

February 7, 2019 18:26


          Merge branch 'develop' into refactored-gas-test-history

d3e076b


          Moved toBytesHexString to helpers/utils

2feb85a

Added toHex to `helpers/utils`
Ignoring .nyc_output
Update references to toBytesHexString

davidmurdoch suggested changes

View reviewed changes

test/call/undefined.js Outdated Show resolved Hide resolved

test/gas/gasLimit.js Outdated Show resolved Hide resolved

test/helpers/contract/compileAndDeploy.js Outdated Show resolved Hide resolved

ccowell added 5 commits

February 11, 2019 12:06


          Removed toHex from helpers/utils

da75e8e


          JSDocumented receipt in bootstrap and compileAndDeploy

5f628b3


          Replaced mnemonics with random seed


          Updated comments

f36923f


          Removed initialization for context references

731523e

Contributor Author

ccowell commented Feb 12, 2019

So many of these tests are validating that an option was properly handled/observed. Given that this is mostly following a pattern of "set option to nondefault value then validate that the option was set", I wonder if this couldn't/shouldn't be handled by a test helper. That way we could have a single "it observes gas options" test which just runs through a list of options

Extracting the options to a helper file would be ideal and a great start to increasing coverage stats. We can target this during the next refactoring pass through.

ccowell and others added 13 commits

February 12, 2019 16:43


          Documentation update.

b516018


          when the number passed to web3's toWei is a BN it returns a BN

d19db39


          Removed process.removeAllListeners('uncaughtException') from tests

b979487


          Updated documentation

e259b7c


          Combined contract files and subdirectory path into an object when boo…

18fb0b9

…tstrapping


          Replaced mnemonic with seed for gas.js

c5526e8


          Renamed a variable name to be more descriptive

0bc18ed


          Update JSDoc

335793d


          add number-to-bn as a dev dependency

20dc50e


          refactor some of gas.js


          Merge branch 'refactored-gas-test-history' of https://github.com/truf…

56b525c

…flesuite/ganache-core into refactored-gas-test-history


          remove underscores from gas test files

be82dd5


          update npm-shrinkwrap.json

davidmurdoch approved these changes

View reviewed changes

davidmurdoch dismissed benjamincburns’s stale review

February 13, 2019 17:42

Ben has better things to do right now. :-D

davidmurdoch merged commit 86d565b into develop

davidmurdoch deleted the refactored-gas-test-history branch

February 20, 2019 15:21

This was referenced Feb 28, 2019

Bump ganache-cli from 6.1.8 to 6.4.0 dekz/defi-test-stack#34

Closed

Bump ganache-cli from 6.1.6 to 6.4.1 0xProject/0x-starter-project#107

Closed

chore(deps-dev): bump ganache-cli from 6.2.3 to 6.4.1 marcoonroad/instrumental#72

Closed

Bump ganache-cli from 6.1.8 to 6.4.1 dekz/defi-test-stack#37

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.