Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Handle invalid block numbers in eth_getTransactionCount #291

Merged
merged 2 commits into from Feb 20, 2019
Merged

Handle invalid block numbers in eth_getTransactionCount #291

merged 2 commits into from Feb 20, 2019

Conversation

davidmurdoch
Copy link
Member

No description provided.

nicholasjpaterno
nicholasjpaterno approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@nicholasjpaterno nicholasjpaterno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch on this! Who would have thought to pass an empty string? 💯

We can potentially take advantage of pify or helpers/utils::generateSend in the test.

@davidmurdoch davidmurdoch merged commit acde383 into develop Feb 20, 2019
@davidmurdoch davidmurdoch deleted the transaction-count-invalid-block-number branch February 20, 2019 15:20
This was referenced Feb 28, 2019
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicholasjpaterno nicholasjpaterno nicholasjpaterno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidmurdoch @nicholasjpaterno