Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fix getTransactionCount leading zeros in hex string #32

Merged
merged 5 commits into from
Dec 26, 2017
Merged

Fix getTransactionCount leading zeros in hex string #32

merged 5 commits into from
Dec 26, 2017

Commits on Nov 19, 2017

  1. Fix hexWithoutLeadingZeroes when value is 0

    @natanrolnik
    natanrolnik committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    cd0f046 View commit details
    Browse the repository at this point in the history

  2. Format response in getTransactionCount as hex without leading zeros

    @natanrolnik
    natanrolnik committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    6002841 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2017

  1. Add tests for to.hexWithoutLeadingZeroes

    @attente
    attente committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    a720023 View commit details
    Browse the repository at this point in the history

  2. Test for leading zeros in JSON-RPC response 

    From https://github.com/ethereum/wiki/wiki/JSON-RPC#hex-value-encoding:

"When encoding QUANTITIES (integers, numbers): encode as hex, prefix
with '0x', the most compact representation (slight exception: zero
should be represented as '0x0'). Examples:"

"WRONG: 0x0400 (no leading zeroes allowed)"
    @attente
    attente committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    ebb74a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2017

  1. Merge pull request #2 from attente/fix-transaction-count-leading-zeros 

    Add tests for leading zeros in hex values
    @natanrolnik
    natanrolnik committed Nov 28, 2017
    Configuration menu
    Copy the full SHA
    cd55e15 View commit details
    Browse the repository at this point in the history