This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: remove unnecessary TODOs from api, update TODOs with issue numbers #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
suggested changes
Aug 3, 2022
src/chains/ethereum/ethereum/src/data-managers/blocklog-manager.ts
Outdated
Show resolved
Hide resolved
jeffsmale90
approved these changes
Aug 3, 2022
tenthirtyone
changed the title
…r.ts Co-authored-by: Micaiah Reid <micaiahreid@gmail.com>
MicaiahReid
approved these changes
Aug 4, 2022
davidmurdoch
approved these changes
Aug 4, 2022
davidmurdoch
changed the title
|
I've updated the PR title to reflect the plural changes of the PR. When merging this can make sure sure the commit message reflects this change? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Housekeeping to update code TODOs with links to matching Issues.