Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

test: replace assert.equal with assert.strictEqual in tests #3508

Merged
merged 4 commits into from Aug 11, 2022
Merged

test: replace assert.equal with assert.strictEqual in tests #3508

merged 4 commits into from Aug 11, 2022

Conversation

gr7d
Copy link
Contributor

@gr7d gr7d commented Aug 8, 2022

Fixes #3504

@gr7d gr7d requested a review from davidmurdoch as a code owner August 8, 2022 15:38
@jeffsmale90 jeffsmale90 self-requested a review August 8, 2022 21:44
@MicaiahReid MicaiahReid self-requested a review August 10, 2022 17:56
@MicaiahReid
Copy link
Contributor

Thanks for the PR, @l2ig!

@jeffsmale90
Copy link
Contributor

Nice! I love consistency :)

davidmurdoch
davidmurdoch approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l2ig, thanks for doing this! Would you like to tackle #3530 as well? :-D

@davidmurdoch davidmurdoch changed the title refactor: replace assert.equal with assert.strictEqual in tests test: replace assert.equal with assert.strictEqual in tests Aug 11, 2022
@davidmurdoch
Copy link
Member

Note: I've updated the PR title to use the test: prefix as this change "corrects existing tests".

@davidmurdoch davidmurdoch merged commit 1592b1d into trufflesuite:develop Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@jeffsmale90 jeffsmale90 jeffsmale90 approved these changes

@MicaiahReid MicaiahReid MicaiahReid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: check for cases where assert.equal is used where assert.strictEqual is preferred in unit tests
4 participants
@gr7d @MicaiahReid @jeffsmale90 @davidmurdoch