Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: assume unknown tx type is TransactionType.Legacy #3523

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix: assume unknown tx type is TransactionType.Legacy #3523

merged 2 commits into from
Aug 17, 2022

Conversation

jaketimothy
Copy link
Contributor

Fixes #3489
Fixes #3458

@jaketimothy
Copy link
Contributor Author

Let me know if this is too permissive

Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm cool with this. Thanks for the PR!

I would like to note - this should fix your problems with Arbitrum Nitro throwing with an "invalid transaction types" error, but we still won't actually support these transaction types. Or any non EVM compatible chains. (I know, Arbitrum claims to be EVM compatible, then they go and start making up transaction types! 😅 )

We are working on a plugin system so that users can extend Ganache to work with different L2s. Keep an eye on our releases for when this will be available. Thanks again!

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing the work for this. I just have one change request.

@davidmurdoch
Copy link
Member

Thanks @jaketimothy for those quick test updates. Tests are running now and we'll get this approved and merged soon!

@jaketimothy
Copy link
Contributor Author

@davidmurdoch lmk if there's anything more I can take care of here!

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants