Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

ci: add config for semantic-prs app #3543

Merged
merged 4 commits into from
Aug 23, 2022
Merged

Conversation

MicaiahReid
Copy link
Contributor

This change adds a semantic.yml file to configure how the Semantic-PRs app interacts with Ganache. This app will now require that all pull requests have a title with a conventional commit message.

@MicaiahReid MicaiahReid changed the title add config for semantic-prs app ci: add config for semantic-prs app Aug 16, 2022
@jeffsmale90
Copy link
Contributor

This all looks fine - as an aside https://github.com/trufflesuite/ganache/blob/develop/CONTRIBUTING.md#pull-requests doesn't mention anything about PR title / description. Is that worth updating now / in the future?

@jeffsmale90
Copy link
Contributor

For anyone looking, here's the documentation for the GH integration: https://github.com/Ezard/semantic-prs#readme

Copy link
Contributor

@tenthirtyone tenthirtyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

I need this in my life.

CONTRIBUTING.md Show resolved Hide resolved
@MicaiahReid MicaiahReid merged commit 05420db into develop Aug 23, 2022
@MicaiahReid MicaiahReid deleted the require-semantic-prs branch August 23, 2022 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants