This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
ci: fix docker publish #3619
Merged
ci: fix docker publish #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmurdoch
reviewed
Sep 6, 2022
MicaiahReid
force-pushed
the
ci-fix-docker-publish
branch
from
ea84124
to
a456d18
Compare
davidmurdoch
approved these changes
Sep 7, 2022
jeffsmale90
approved these changes
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was tested as an alpha release. The run can be seen here: https://github.com/trufflesuite/ganache/runs/8215680896?check_suite_focus=true
The problem with the original PR (#3547) that this fixes was that the environment variables are not persisted from job to job. This fix saves those environment variables that are needed in the subsequent docker publish job.