This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
chore: upgrade @ethereumjs/vm to v6.0.0 #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
force-pushed
the
ejsbeta
branch
2 times, most recently
from
27cd6b7
to
3819313
Compare
MicaiahReid
commented
Sep 15, 2022
MicaiahReid
commented
Sep 15, 2022
MicaiahReid
commented
Sep 15, 2022
jeffsmale90
suggested changes
Sep 21, 2022
src/chains/ethereum/ethereum/src/data-managers/transaction-receipt-manager.ts
Show resolved
Hide resolved
jeffsmale90
suggested changes
Sep 22, 2022
| const intToBuffer = (value: number) => | ||
| value === 0 ? BUFFER_EMPTY : uintToBuffer(value); | ||
| const _bigintToBuffer = (value: bigint) => | ||
| value === 0n ? BUFFER_EMPTY : bigIntToBuffer(value); |
There was a problem hiding this comment.
Should we build this into bigIntToBuffer? Seems like a logical thing to do in all cases, not just this one.
| @@ -381,7 +381,7 @@ describe("@ganache/ethereum-transaction", async () => { | |||
| assert.notDeepStrictEqual(vmTx.hash().toString(), ""); | |||
| }); | |||
| it("has nonce property", () => { | |||
| assert.strictEqual(vmTx.nonce.toString(), "0"); | |||
| assert("nonce" in vmTx); | |||
There was a problem hiding this comment.
We are no longer asserting the value of nonce here
MicaiahReid
force-pushed
the
ejsbeta
branch
from
0e3fa02
to
d964e1c
Compare
MicaiahReid
changed the title
MicaiahReid
force-pushed
the
ejsbeta
branch
from
27e0ad6
to
cce3003
Compare
MicaiahReid
added a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: David Murdoch <david@davidmurdoch.com>
MicaiahReid
added a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: David Murdoch <david@davidmurdoch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3473
Fixes #3578