Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: use zero address when unable to calculate 'from' #3660

Closed
wants to merge 1 commit into from

Conversation

gBaGu
Copy link

@gBaGu gBaGu commented Sep 15, 2022

I'm trying to fork a evm-compatible chain with ganache-ui, but my chain contains custom signatures and when block that is used as a fork point has transaction with custom signature ganache application crashes on Transactions screen.
The problem comes from Transaction.from getter function which throws if signature is invalid and causes ui to crash.
This PR simply uses zero address as 'from' field instead of throwing an exception.

@gBaGu gBaGu changed the title Use zero address when unable to calculate 'from' fix: use zero address when unable to calculate 'from' Sep 15, 2022
@davidmurdoch
Copy link
Member

Ganache-UI hasn't been updated to use the latest version of Ganache. Your fix here would certainly make UI stop crashing... but would ultimately just make the implementation completely incorrect.

@gBaGu
Copy link
Author

gBaGu commented Sep 15, 2022

Is there another way to handle invalid signatures without crashing?

@davidmurdoch
Copy link
Member

Does Ganache v7 (npm install ganache --global and then run ganache --fork.url <YOUR URL HERE>) return errors when you try to use it?

What chain are you using?

@gBaGu
Copy link
Author

gBaGu commented Sep 21, 2022

@davidmurdoch cli Ganache works fine. So my only option is to use command line Ganache instead of UI?
I'm using Velas chain

@davidmurdoch
Copy link
Member

Ganache UI hasn't been updated yet.

@gBaGu
Copy link
Author

gBaGu commented Sep 28, 2022

@davidmurdoch will it be updated any time soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants