This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
perf: use keccak from @ganache/utils where possible
#3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
force-pushed
the
swap-hash-functions
branch
from
6b39cc4
to
adb9870
Compare
davidmurdoch
approved these changes
Oct 24, 2022
jeffsmale90
approved these changes
Oct 28, 2022
jeffsmale90
reviewed
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest releases of
@ethereumjs/utiland@ethereumjs/trieswap out their previous keccak function to use the less performant ethereum-cryptography package instead. This change uses the keccak exported from@ganache/utilsinstead, where possible.