Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Fix forked transaction trace storage so it returns the correct data and doesn't modify the root trie #398

Merged
merged 14 commits into from
Apr 5, 2019
Merged

Fix forked transaction trace storage so it returns the correct data and doesn't modify the root trie #398

merged 14 commits into from
Apr 5, 2019

Commits on Mar 26, 2019

  1. Fix forkedblockchain.js, correctly handle buffer encoded hash values

    @nicholasjpaterno @davidmurdoch
    nicholasjpaterno authored and davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    2c2814c View commit details
    Browse the repository at this point in the history

  2. Add test for forked debugging

    @nicholasjpaterno @davidmurdoch
    nicholasjpaterno authored and davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    a874c78 View commit details
    Browse the repository at this point in the history

  3. Fix forkedblockchain.js, convert buffer to hex encoded string 

    We don't use to.hex since we check/know the type is buffer and so we can
reduce the overhead by converting to hex string directly.
    @nicholasjpaterno @davidmurdoch
    nicholasjpaterno authored and davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f916070 View commit details
    Browse the repository at this point in the history

  4. add valid tests and remove the other ones for now

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    e018b24 View commit details
    Browse the repository at this point in the history

  5. only 1 test failure now

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    99f11ed View commit details
    Browse the repository at this point in the history

  6. fix the last failure

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    8e14303 View commit details
    Browse the repository at this point in the history

  7. dead code removal

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    6ef8f5b View commit details
    Browse the repository at this point in the history

  8. .

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    ed84aa7 View commit details
    Browse the repository at this point in the history

  9. refactor some things

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    c1fccb4 View commit details
    Browse the repository at this point in the history

  10. cleanup

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    bcebac2 View commit details
    Browse the repository at this point in the history

  11. cleanup

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    55494b2 View commit details
    Browse the repository at this point in the history

  12. add todo

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    73e5982 View commit details
    Browse the repository at this point in the history

  13. simplify

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    11a0945 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'develop' into fix-forked-transaction-trace-storage

    @davidmurdoch
    davidmurdoch committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    26e6d43 View commit details
    Browse the repository at this point in the history