-
Notifications
You must be signed in to change notification settings - Fork 673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see suggestions
Co-authored-by: David Murdoch <187813+davidmurdoch@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @MicaiahReid, just one small nit, which won't hold back my approval.
|
||
#### v7.7.0+, Dropped support for Node v12 | ||
|
||
We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer support Node v12. You'll need to update to Node v14.0.0 or later. NOTE: Support for Node.js v14.x.x will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. | |
We no longer support Node v12. You'll need to update to Node v14 or later. NOTE: Support for Node.js v14 will be dropped shortly after the Node.js Foundation stops supporting it in April 2023. |
I think the extra zeros and .x.x
are confusing in this context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree; this is saying you currently need at least the lowest v14, which is 14.0.0. And that we will drop support for all node v14 versions, 14.x.x
You know when you spend a really long time on a big PR and finally think you've got every little detail settled, then the whole team reviews the PR and finds a few other little things that you fix, then they all approve the PR, so you all think you've got every little detail settled, then you finally merge the PR and you immediately realize that you forgot to remove a now unsupported version of node from your CI tests that only run once the PR has been merged into develop, so now you have to make another PR to remove the now unsupported node version from your CI tests? Yeah I hate when that happens.