This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: handle eth_gasEstimate reverts correctly to prevent potential process crash
#4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidmurdoch originally I was deploying a contract that throws in the constructor, but figured this was a simpler way to cause the estimator to fail. LMK what you think. |
davidmurdoch
commented
Dec 18, 2022
davidmurdoch
changed the title
eth_gasEstimate reverts correctly to prevent potential process crash
|
Code coverage in the problematic function with @jeffsmale90's test is now:
|
MicaiahReid
approved these changes
Dec 19, 2022
tenthirtyone
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to support the Merge hardfork code that handled
eth_gasEstimatewas refactored. A code block that previously "short circuited" the function no longer did, causing a JavaScript Promise to be fullfilled with a handled rejection, but then also an unhandled rejection.We've fixed the short circuit code and added a test to prevent this from regressing in the future.