This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Added eth_chainId #419
Merged
Added eth_chainId #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidmurdoch the Travis build is still failing for Node.js v12, can we merge this anyway and therefore close issue #339? |
imbenwolf
approved these changes
Jun 24, 2019
|
Guys, web3 and ganache are not working on the latest version. Please fix/merge this PR and release a new version. We are relying on new API changes of the web3 library and if ganache does not manage to keep up we will have to switch development strategy for test chains. keep in mind, this issue has been known since the 26.02.2019 and fixed (rather well imho) by @tcichowicz since 11 days! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339
Latest betas of web3.js have trouble cooperating with ganache because
eth_chainIdwas unsupported. This PR adds support for handling such requests.