This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: add support for mergeForkIdTransition
#4463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able, just fetch from the fork ¯\_(ツ)_/¯
…to instantiate a transaction in order to serialize it for the database. Except where we need the effective gas price for an eip-1559 fee market transaction, because we need to know the block basefeepergas :(
|
|
||
| blocknumberToHardfork.forEach(([number, expectedHardfork]) => { | ||
| const common = fork.getCommonForBlock(parentCommon, { | ||
| number, // the block at which paris is scheduled |
There was a problem hiding this comment.
apologies, the base branch was wrong here - as it depends on #4455 where I've fixed this, along with a minor change to the above comment https://github.com/trufflesuite/ganache/pull/4455/files/cb95798713916bda17494b7129aa8eb99220a786..163c987b7d9dbdf24eee0cc5569af085cf318989
davidmurdoch
approved these changes
Jun 30, 2023
Deploying with
|
| Latest commit: |
ca9509c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7dcca892.ganache.pages.dev |
| Branch Preview URL: | https://fix-mergeforkidtransition.ganache.pages.dev |
This was referenced Sep 23, 2023
This was referenced Nov 23, 2023
This was referenced Apr 16, 2024
This was referenced Apr 17, 2024
This was referenced May 6, 2024
This was referenced May 7, 2024
This was referenced May 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add internal support for
mergeForkIdTransition"hardfork", which is presently live only on Sepolia, but assumedly will eventually happen on other networks.This doesn't add any functionality, but fixes: #4450 for transactions happening on
mergeForkIdTransitionhardfork.See #4455