This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: eth_call and eth_estimate gas limits (mostly)
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasjpaterno
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix raises the default gas limit for
eth_callandeth_estimateGasto be much much higher.It also adds an a new option
callGasLimitwhich will be the default value fortxandblockgas limits for calls and estimates.Ideally we'd allow for Infinity. But the VM doesn't allow for that.
We could go higher with this limit if we change the gas est algo to handle BigInt-sized numbers, but currently it doesn't so
Number.MAX_SAFE_INTEGERit is!