This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Updated Receipt's logIndexto be index position in the _block_,. #596
#463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sushilbal nice work! The only thing we would need to merge this is a test case! This is actually a good chance for us to formally test describe("eth_getFilterChanges", function() {
it("should contain the correct logIndex", function() {
});
});Something like this in |
davidmurdoch
changed the title
logIndexto be index position in the _block_,. #335logIndexto be index position in the _block_,. #596
|
Closing as this has been fixed in the |
cometwebdev
added a commit
to cometwebdev/saddle-contract
that referenced
this pull request
Jan 31, 2022
* Add withdrawal fee that decays over a year * Fee cannot exceed 1% * If user adds more liquidity before the decaying is over, it recalculates the fee which gets discounted based on the previous deposit amount & time. Then the decaying period is extended to a year from the second deposit. * Make withdrawFee a multiplier such that updating the fee applies retroactively as well * Changes withdrawFee to withdrawFeeMultiplier * Adds more comments * Change evm_setNextBlockTimestamp to evm_increaseTime * Though builder evm supports both calls, coverage uses ganache network which only supports latter. * Use evm_mine to specify timestamp * Due to ganache's design of interpreting evm_increaseTime, there is extra 1 second added to the block depending on Javascript runtime, * https://ethereum.stackexchange.com/questions/73751/understanding-ganache-timestamps * trufflesuite/ganache#463 * Use evm_mine during coverage (Ganache) and evm_setNextBlockTimestamp during test (Buidler EVM) * Rebased and updated function calls to support deadlines * Change decay period to 4 weeks * Fix comments * Fix another typo * Fix github ci * Replaces ssh with https Co-authored-by: Sunil Srivatsa <sunilsrivatsa@gmail.com>
melbesnard85
added a commit
to melbesnard85/saddle-contract
that referenced
this pull request
May 7, 2022
* Add withdrawal fee that decays over a year * Fee cannot exceed 1% * If user adds more liquidity before the decaying is over, it recalculates the fee which gets discounted based on the previous deposit amount & time. Then the decaying period is extended to a year from the second deposit. * Make withdrawFee a multiplier such that updating the fee applies retroactively as well * Changes withdrawFee to withdrawFeeMultiplier * Adds more comments * Change evm_setNextBlockTimestamp to evm_increaseTime * Though builder evm supports both calls, coverage uses ganache network which only supports latter. * Use evm_mine to specify timestamp * Due to ganache's design of interpreting evm_increaseTime, there is extra 1 second added to the block depending on Javascript runtime, * https://ethereum.stackexchange.com/questions/73751/understanding-ganache-timestamps * trufflesuite/ganache#463 * Use evm_mine during coverage (Ganache) and evm_setNextBlockTimestamp during test (Buidler EVM) * Rebased and updated function calls to support deadlines * Change decay period to 4 weeks * Fix comments * Fix another typo * Fix github ci * Replaces ssh with https Co-authored-by: Sunil Srivatsa <sunilsrivatsa@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the log index to be in sync with the number of logs in the block rather than determined by the number of transactions