fix: ensure txs in forked mode can access uncommitted code state #488

nicholasjpaterno · 2019-09-26T19:11:39Z

Allows the newer VM to reference it's cache.

Resolves #454

We keep getCode for RPC calls

coveralls · 2019-09-26T19:15:07Z

Coverage decreased (-0.08%) to 82.172% when pulling 43eab49 on fix/forked-vm-internal-cache into ca16291 on develop.

nicholasjpaterno added 5 commits September 26, 2019 14:16

Add test contract - forking and intra block state

3dc33e7

Add test for intra block state

369937e

Remove VM patch for getCode

e78c691

Remove .only and add assertion

4587685

Remove getCode from VM patch

43eab49

We keep getCode for RPC calls

nicholasjpaterno requested a review from davidmurdoch September 26, 2019 19:11

davidmurdoch changed the title ~~Fix forked vm, remove getCode patch~~ fix: make sure transactions in forked mode can access uncommitted code state Sep 26, 2019

davidmurdoch approved these changes Sep 26, 2019

View reviewed changes

davidmurdoch changed the title ~~fix: make sure transactions in forked mode can access uncommitted code state~~ fix: ensure txs in forked mode can access uncommitted code state Sep 26, 2019

davidmurdoch merged commit 34cdd8a into develop Sep 26, 2019

davidmurdoch deleted the fix/forked-vm-internal-cache branch September 26, 2019 20:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure txs in forked mode can access uncommitted code state #488

fix: ensure txs in forked mode can access uncommitted code state #488

nicholasjpaterno commented Sep 26, 2019 •

edited

Loading

coveralls commented Sep 26, 2019

fix: ensure txs in forked mode can access uncommitted code state #488

fix: ensure txs in forked mode can access uncommitted code state #488

Conversation

nicholasjpaterno commented Sep 26, 2019 • edited Loading

coveralls commented Sep 26, 2019

nicholasjpaterno commented Sep 26, 2019 •

edited

Loading