Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

feat: add support for additional methods used by js-lotus-client-workshop #718

Conversation

mikeseese
Copy link
Contributor

This PR is part of #693:

  • Implements Filecoin.Version method
  • Implements Filecoin.ActorAddress method
  • Implements initial Filcoin.StateMinorInfo method

@mikeseese mikeseese changed the title add support for additional methods used by js-lotus-client-workshop feat: add support for additional methods used by js-lotus-client-workshop Jan 15, 2021
Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change requests, just comments.

src/chains/filecoin/filecoin/src/api.ts Show resolved Hide resolved
},
sectorSize: {
serializedName: "SectorSize",
defaultValue: 18446744073709551615n // max from https://bit.ly/2XJItAg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(2n**64n) - 1n, if you cared to compress this giant number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy-pasted this from the spec; I'd rather have a copied number than a grokable one here

src/chains/filecoin/filecoin/src/things/version.ts Outdated Show resolved Hide resolved
@mikeseese mikeseese force-pushed the fix/filecoin-storagedealstates-update branch from 5954ac6 to 2bb0849 Compare January 16, 2021 01:35
@mikeseese mikeseese force-pushed the fix/filecoin-support-lotus-client-workshop branch from 29dbc2b to 4d78760 Compare January 16, 2021 01:36
@mikeseese mikeseese force-pushed the fix/filecoin-storagedealstates-update branch from 2bb0849 to b325d07 Compare January 19, 2021 03:51
@mikeseese mikeseese force-pushed the fix/filecoin-support-lotus-client-workshop branch from 3fa1232 to d3a3cae Compare January 19, 2021 03:52
@mikeseese mikeseese force-pushed the fix/filecoin-storagedealstates-update branch from b325d07 to abcd8e1 Compare January 19, 2021 22:18
@mikeseese mikeseese force-pushed the fix/filecoin-support-lotus-client-workshop branch from d3a3cae to abe4ed9 Compare January 19, 2021 22:19
@mikeseese mikeseese force-pushed the fix/filecoin-storagedealstates-update branch from abcd8e1 to bb83c01 Compare January 20, 2021 21:47
@mikeseese mikeseese force-pushed the fix/filecoin-support-lotus-client-workshop branch from abe4ed9 to 905e98c Compare January 20, 2021 21:47
@mikeseese
Copy link
Contributor Author

We're postponing these reviews until later

@mikeseese mikeseese closed this Jan 21, 2021
@mikeseese mikeseese deleted the fix/filecoin-support-lotus-client-workshop branch January 26, 2021 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants