Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Load solc module in lazy fashion. Saves up to 2s on tests. #19

Merged
merged 4 commits into from Oct 24, 2017
Merged

Load solc module in lazy fashion. Saves up to 2s on tests. #19

merged 4 commits into from Oct 24, 2017

Conversation

zie1ony
Copy link

@zie1ony zie1ony commented Aug 5, 2017

It is handy while working with unit tests.

@zie1ony zie1ony changed the title Load solc module in lazy fashion. Saves up to 2s when compilation is … Load solc module in lazy fashion. Saves up to 2s. Aug 5, 2017
@zie1ony zie1ony changed the title Load solc module in lazy fashion. Saves up to 2s. Load solc module in lazy fashion. Saves up to 2s on tests. Aug 5, 2017
@tcoulter
Copy link
Contributor

This is good. Thanks for the input.

Before we can commit it, we'll need to move the clean up after solc bit (see the original comments in those files) to happen right after the require('solc') otherwise solc's going to rethrow every javascript error prepending error messages with a ton of minified JavaScript (this makes development a nightmare).

CC @gnidan

@gnidan gnidan merged commit ebb9e1b into trufflesuite:develop Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants