This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Integrate Lint-Staged w/ Prettier & light ESLint config + Minimal Linting of Current Codebase #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
approved these changes
Oct 22, 2018
|
@gnidan I can also push an updated package.json with the eslint devDeps and a pretest script to include in CI. Might end up being noise instead of helpful though since there are ~250 warnings that pop up. |
CruzMolina
force-pushed
the
eslint-minimal
branch
from
67bd18b
to
e8a34f8
Compare
CruzMolina
force-pushed
the
eslint-minimal
branch
from
e8a34f8
to
97f3231
Compare
CruzMolina
changed the title
CruzMolina
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran the entire codebase through eslint using a very minimal setting (no-unused-vars, semi, indent (2 spaces), & block-spacing). Inspired by a quest to eliminate our unused global requires.
There are still a number of unused local vars (~100?) I erred on the side of leaving alone for now, I also only lightly touched truffle-debugger.
Moving forward, I've added
lint-stagedto run w/prettierandeslint(minimal settings) precommit. Hopefully this helps minimize stylistic reviews and bikeshedding.