Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Factor out calldata struct decoding #1811

Merged
merged 1 commit into from Mar 14, 2019
Merged

Factor out calldata struct decoding #1811

merged 1 commit into from Mar 14, 2019

Conversation

haltman-at
Copy link
Contributor

This PR factors out calldata struct decoding into its own function to reduce the amount of copypaste. It contains no functional changes (or at least, it shouldn't).

Notes:

  1. I didn't factor out array decoding; I didn't think that really needed it.
  2. I didn't include memory struct decoding, even though that also works essentially the same now, because, well, that wouldn't have been so convenient. In any case I think the copypaste, while not gone, is now down to levels I'd consider acceptable.

@haltman-at haltman-at requested a review from gnidan March 13, 2019 01:02
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @haltman-at!

@haltman-at haltman-at merged commit 736ff8b into develop Mar 14, 2019
@haltman-at haltman-at deleted the calldata-factoring branch March 14, 2019 03:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants