Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Handle non-integer truffle develop network_id values #1825

Merged
merged 2 commits into from Mar 19, 2019
Merged

Handle non-integer truffle develop network_id values #1825

merged 2 commits into from Mar 19, 2019

Conversation

CruzMolina
Copy link
Contributor

This PR is a fix for #1824 .

Since truffle develop is now configurable, we need to sanitize & handle invalid network_id values.

☕️

@CruzMolina CruzMolina requested a review from gnidan March 15, 2019 18:08
@CruzMolina CruzMolina requested a review from gnidan March 16, 2019 00:12
gnidan
gnidan approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙

@CruzMolina CruzMolina merged commit 538482d into develop Mar 19, 2019
@CruzMolina CruzMolina deleted the sanitize-develop-networkID branch March 19, 2019 15:43
@CruzMolina CruzMolina mentioned this pull request Mar 21, 2019
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnidan gnidan gnidan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CruzMolina @gnidan