Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Improvement: Support globally installed npm #1851

Merged
merged 6 commits into from Apr 23, 2019

Conversation

tagomaru
Copy link
Contributor

Truffle does not support globally installed npm now.
This PR resolves it.

@CruzMolina CruzMolina changed the base branch from next to develop April 15, 2019 22:16
@CruzMolina
Copy link
Contributor

Cool @tagomaru ! Changed the base branch to target develop & updated your branch to see if it that will fix the build. Would be nice to have some tests for this.

@coveralls
Copy link

coveralls commented Apr 15, 2019

Coverage Status

Coverage increased (+0.1%) to 69.722% when pulling 9d820a9 on tagomaru:support-global-npm into d3bb42b on trufflesuite:develop.

@tagomaru
Copy link
Contributor Author

@CruzMolina
Thx for ur review and updating !
OK, i will write a test for this.

@tagomaru
Copy link
Contributor Author

@CruzMolina
Hey, I wrote test code of globalnpm.
Could you kindly check this commit ?

Thx!

@CruzMolina CruzMolina self-assigned this Apr 18, 2019
@CruzMolina
Copy link
Contributor

Reviewing shortly @tagomaru 🔬

@CruzMolina CruzMolina requested a review from gnidan April 19, 2019 16:03
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and LGTM.
Thanks for doing this @tagomaru !

@CruzMolina CruzMolina merged commit 3ce1d5e into trufflesuite:develop Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants