This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Update truffle test code #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and update some vars to consts
1 task
eggplantzzz
changed the title
fainashalts
reviewed
Jun 11, 2019
fainashalts
reviewed
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of making the code for truffle test more readable and maintainable, this PR was created! It removes the callback being passed to the run method for
packages/truffle-core/lib/test.jsand instead adopts a Promise-based interface. The callback is now being handled inpackages/truffle-core/lib/commands/test.js. The war on callbacks wages on!