Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add native tag to parser test needing docker/native #2108

Merged
merged 1 commit into from Jun 18, 2019
Merged

Add native tag to parser test needing docker/native #2108

merged 1 commit into from Jun 18, 2019

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Jun 18, 2019

(Internal improvement)

Mark a few truffle-compile tests as being @native because they use Docker. I've seen this done elsewhere so I assume it's kosher?

CruzMolina
CruzMolina approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🏷

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 70.231% when pulling 7b5a043 on missing-native-tag into ac29ad5 on develop.

@gnidan
Copy link
Contributor Author

gnidan commented Jun 18, 2019

Thanks!

@gnidan gnidan merged commit 869ca9a into develop Jun 18, 2019
@gnidan gnidan deleted the missing-native-tag branch June 18, 2019 04:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CruzMolina CruzMolina CruzMolina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnidan @coveralls @CruzMolina