New Feature: Hyperledger Integration (chaincode-fabric-evm)

[CruzMolina]

This PR builds on top of prior work in #1806 to implement chaincode-fabric-evm integration.

⛓

Example truffle-config.js for using Truffle with chaincode-fabric-evm:

module.exports = {
  networks: {
    development: {
      ...
      type: "fabric-evm"
      ...
    }
  }
};

[coveralls]

Coverage increased (+0.02%) to 70.403% when pulling 5401704 on chaincode-fabric-evm into be4b664 on develop.

[gnidan]

It's great that the override here is rather tiny! Thanks for all the tests to get things started with good practice.

Mostly my suggestions here are on code organization, since this brings us to three network types.

[gnidan]

Looks good apart from the one comment!

[gnidan]

hooray!

[gnidan]

Naming note here, not to change for this PR, but we might want to fix at some point:

For explicitness purposes, these methods should probably include the word override or something similar, to convey that it's not that we're getting the block, but we're overriding how we get the block.

An alternative solution would be to abstract this, so that getBlock, getTransaction, would be in a mapping, something like:

const overrides = {
  "getBlock": (original) => {
    const _oldFormatter = original.method.outputFormatter;
    original.method.outputFormatter = (block) => {
      _oldFormatter.call(original, block);
      /* ... */
    };
  },
  /* ... */
}

Just if you want to keep this in the back of your mind for whenever.

[gnidan]

Not blocking approval, but I think we should fix the name here to reflect that this specifically relates to which network types use the legacy system. Maybe getLegacyNetworkTypes.

Ooh, we could take this a step further! We can add requiresLegacySystem as a boolean field on the Definition objects, and that way it becomes a lot more cohesive when adding a new network. Basically, just these steps:

1. Create an overrides file + definition
2. Import the definition and link it up in the web3-shim module