This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Reduce unnecessary repetition of loops #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltman-at
approved these changes
Apr 20, 2020
No need to loop through to `filter` then `reduce`. SInce filter can be implemented with a reduce we can reduce the need to loop through `expr.split(".")`'s output twice.
`Object.keys(obj)` is actually a `O(n)` operation. Lets do this once and save the output.
We can also eliminate the need to map (`O(n)`) this before passing the result to Math.max which is a `O(n)` operation as well. If we just perform the operation in one `reduce` statement.
Nothing imperative here, just low hanging fruit.
nicholasjpaterno
force-pushed
the
nicholasjpaterno-patch-printer.js
branch
from
894c47c
to
78949db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to loop through with
filterthenreduce. Since filter can be implemented with a reduce we can eliminate the need to loop throughexpr.split(".")'s output twice.Object.keys(obj)is actually aO(n)operation. Lets do this once and save the output.We can also eliminate the need to map (
O(n)) this before passing the result to Math.max which is aO(n)operation as well. If we just perform the operation in onereducestatement.Nothing imperative here, just low hanging fruit.