This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency update: Update Mocha to version 8 #3146
Dependency update: Update Mocha to version 8 #3146
Changes from all commits
3e55bc7
6fbd31d
3f19f30
1f5ac1f
afba441
22f4cdc
56feea0
21aa179
078ea1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
mocha
(the one incore
, the dependency, not the dev dependency) is exposed to the user... so isn't upgrading this one a breacking change? Should this one be left as is?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There could be some edge cases when doing customizable
mocha
-things (mocha-parallel tests
?), but so far the core CLI functionality when runningtruffle test
seems about the same.I haven't checked the Library API we expose (
truffle.test
...), but last I checked it's undocumented and still considered experimental. 🤷♂️Maybe we should dig in and outline what exactly the breaking changes are between v5.2.0 and v8.
FWIW, I don't think
truffle
has ever fully supported the complete features ofmocha
.