This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: Update doc comment about externalSolidity flag #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
externalSolidityflag on codec'sCompilationtype used to be for Solidity only (OK or notionally also Yul), but due to #3212 it should now be safe to use with any language. I never updated the comment, though, and it's part of our codec documentation so I really should. So, did that here.I could have changed the name of the flag, but that seemed more trouble than it was worth, so I left it alone. Can change that though if people think that should really be done. Obviously then I'd have to change it where it's used as well.