This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Update version of Geth used in CI #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggplantzzz
changed the title
eggplantzzz
changed the title
|
Without further changes it (still) looks like the most recent version of Geth that Truffle CI plays well with is 1.10.3. Locally I'm able to successfully run migrations against 1.10.8. |
eggplantzzz
force-pushed
the
geth-version
branch
from
5d19e0d
to
965a1e0
Compare
eggplantzzz
force-pushed
the
geth-version
branch
2 times, most recently
from
cb490f3
to
e997f3e
Compare
eggplantzzz
force-pushed
the
geth-version
branch
from
1d3a8f5
to
9dfe711
Compare
cds-amal
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Nice @eggplantzzz! I love the TIL moments reviewing your PRs.
packages/truffle/test/sources/migrations/error/migrations/10_migrations_funds_geth.js
Show resolved
Hide resolved
cds-amal
reviewed
Sep 2, 2021
…igrations_funds_geth.js Co-authored-by: cds-amal <cds.sudama@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the version of Geth used by the CI as web3 should be compatible with the stable version now.