This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Respect solc version when importing ABI JSON files inside Solidity code #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a good idea! Can you make an issue so we don't lose it? |
|
Yep seems more is needed here. Oops! |
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
d52b374
to
bc4836f
Compare
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
bc4836f
to
1ae2a02
Compare
gnidan
force-pushed
the
resolver/compiler-info
branch
from
21f8ef6
to
dafb5f6
Compare
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
1ae2a02
to
f883dc6
Compare
gnidan
force-pushed
the
resolver/compiler-info
branch
from
dafb5f6
to
9258396
Compare
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
f883dc6
to
2822e3e
Compare
gnidan
force-pushed
the
resolver/compiler-info
branch
2 times, most recently
from
c9968ec
to
d57ab0c
Compare
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
2822e3e
to
161379a
Compare
gnidan
force-pushed
the
resolver/compiler-info
branch
from
d57ab0c
to
eb6f72f
Compare
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
161379a
to
e1b09bc
Compare
gnidan
added
⏸️ merge after target
|
|
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
e1b09bc
to
34d41b9
Compare
|
OK, now this no longer needs to be merge-after-target, right? :) |
gnidan
removed
the
⏸️ merge after target
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
34d41b9
to
8588ebd
Compare
- Ensure we pass solc version info to abi-to-sol - Strip off `+commit.<hash>.<build>` suffix from argument
gnidan
force-pushed
the
upgrade-abi-to-sol
branch
from
8588ebd
to
9e2ef8e
Compare
gnidan
dismissed
cds-amal’s stale review
This approval was from a time when we thought this upgrade would be easy
haltman-at
reviewed
Nov 20, 2021
haltman-at
approved these changes
Nov 20, 2021
|
Thanks! Will merge when green. |
gnidan
changed the title
gnidan
added
enhancement
and removed
dependencies
|
(Also reworded this to be an enhancement, rather than a dependency update, to be more explicit about the reasoning behind this upgrade.) |
gnidan
changed the title
This was referenced Dec 11, 2021
This was referenced Jun 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades abi-to-sol to ^0.5.1, taking advantage of the new functionality in that package to generate version-specific Solidity output.
In order to accommodate this new functionality, we need to know what Solidity version to generate, and so this PR builds on the work of #4420 by hooking the compiler information into the
ABIResolverSource.Mostly straightforward, but I noticed one gotcha: when
resolver.resolve()receives compiler info, it likely receives a version string containing the full commit and target info. This PR ensures theABIResolverSource strips that off because otherwise abi-to-sol throws an exception.