This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Specify --platform when running solc Docker image #5080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a warning when using Dockerized solc on M1 Macs, since the solc images are distributed for x64, and Docker throws a warning to suggest specifying
--platform
directly:This PR does just that, and the warning goes away!
(In the future, if solc distributes Docker images for other platforms, we might want to revisit this... but I'm guessing that's pretty unlikely)