Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bump pouchdb version #5188

Merged
merged 2 commits into from Jun 14, 2022

Conversation

vdamle
Copy link
Contributor

@vdamle vdamle commented Jun 10, 2022

older version uses a vulnerable version of node-fetch

Output of npm list node-fetch when using truffle:5.5.17 (also checked that the vulnerable version is included in 5.5.18 as well:

| `-- truffle@5.5.17
|   `-- @truffle/db@1.0.10
|     +-- apollo-server@3.8.2
|     | `-- apollo-server-core@3.8.2
|     |   `-- apollo-server-env@4.2.1
|     |     `-- node-fetch@2.6.7  deduped
|     +-- pouchdb@7.2.2
|     | `-- node-fetch@2.6.0               >>>> This is the vulnerable version, updating to `pouchdb:7.3.0` pulls the updated package
|     `-- pouchdb-find@7.3.0
|       `-- pouchdb-fetch@7.3.0
|         `-- node-fetch@2.6.7  deduped

ref: pouchdb/pouchdb#8448

older version uses a vulnerable version of node-fetch
@eggplantzzz
Copy link
Contributor

Thanks for the bump @vdamle!

@haltman-at
Copy link
Contributor

haltman-at commented Jun 13, 2022

Hey @vdamle, your PR is failing the yarncheck job. (It checks that yarn.lock is appropriately up to date.) Could you run yarn on your fork, commit the changes, and push them? Thank you! (Note you can use yarn --ignore-scripts if you want to skip the slow part, which is building Truffle.)

@vdamle
Copy link
Contributor Author

vdamle commented Jun 13, 2022

Thank you for catching that @haltman-at . I didn't follow up on the build status. I've pushed the yarn lock as well now.

Copy link
Contributor

@haltman-at haltman-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this! (Now can we get a second reviewer on this? :) )

Copy link
Contributor

@sukanyaparashar sukanyaparashar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thanks for this @vdamle .

@haltman-at haltman-at merged commit c76dc23 into trufflesuite:develop Jun 14, 2022
@wbt
Copy link
Contributor

wbt commented Jun 22, 2022

Thanks for taking care of this update!
Any chance of getting a release out which includes this?

@gnidan
Copy link
Contributor

gnidan commented Jun 22, 2022

Thanks for taking care of this update!
Any chance of getting a release out which includes this?

We should have this week's release out either tomorrow or Friday!

@cds-amal
Copy link
Member

Hey @wbt, how are you using pouchdb? Is it related to truffle db?

@wbt
Copy link
Contributor

wbt commented Jun 22, 2022

I don't think I'm actually using it at all, except for the time-wasting dive into the npm audit failures reported from this vulnerability. I'm hoping that simply updating to use a release with this patch will fix that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants