This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Dashboard work from task-force week (see description for full list of PRs) #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These markers are there for possible change points.
Also amended the browserlist as it causes an issue with craco and the current version of the library: wevm/wagmi#220 for more info. Committing yarn.lock file also as part of this install.
Code and all elements changed to use wagmi features. Added new code into connector component to also use walletconnct. Tested connections to both metamask and walletconnect to infinity wallet and its working as expected. Still to fully test the transaction loading code from the CLI to the dashboard.
added .idea folder to .gitignore file. reverting yarn.lock as some ursa-optional compiler errors were happening locally.
Web3Provider is now fixed and working as it was with web3react. useProvider hook is not working, had to call connector.getProvider() instead.
Walletconnect RPC return variables are not transformed as they aren't the same as metmask ones.
button to allow disconnecting the wallet and resetting state in app.
Cleaned up imports to be all package relative. Also DashboardProvider.tsx renamed to be default packed export. Buttons cleaned up around site and disconnect button made a small red button.
The joys of MacOS Case Insensitive FS.
yarn fixup (will rebase later)
benjamincburns
force-pushed
the
clean-dash
branch
from
f924fb4
to
346550c
Compare
cliffoo
reviewed
Jun 16, 2022
cliffoo
approved these changes
Jun 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes from the following PRs: