Use newer ethereumjs-util

[wbt]

Hopefully fixes #5260

[gnidan]

Hey @wbt thanks for this! Looks like you need to commit the yarn.lock changes (in addition to whatever that other failure is)

[wbt]

Yeah, it looks like it might actually be more involved with having to adapt to some breaking changes in the dependency.
Unfortunately, I don't have the bandwidth to take that deep dive in right now.

[wbt]

The changelog about known-breaking changes is here.

[gnidan]

Yeah, it looks like it might actually be more involved with having to adapt to some breaking changes in the dependency.
Unfortunately, I don't have the bandwidth to take that deep dive in right now.

dang! maybe someone else will be able to pick this up quickly. anyway, always appreciate your contributions in any capacity 🙏

[eggplantzzz]

So it looks like there was some issue where things that were "mnemonic-like" but invalid were parsed as private keys. I updated the parsing in hdwallet-provider to fix this issue and resolve the test that was failing.

[cds-amal]

Looks good, tests are passing. I have a question about sniffing out a private-key.

[haltman-at]

I think there's a bug in this relating to the private key parsing. I also have some style comments.

[haltman-at]

Hitting approve on this, seems good to me! I think isMnemonicLike would be a better name than isMnemonicPhrase but now that there's a least some validation it doesn't bother me. :P

[haltman-at]

Oh, wait, this is failing CI for some reason...

[cds-amal]

LGTM pending tests ofc :)

[cds-amal]

The updated function names are much better.