This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Use test fixtures in encoder and compile-solidity #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will speed up testing because unboxing from FS is faster than over network
This will speed up testing because unboxing from FS is faster than over network. - add fixture - use helper to setup sandbox
cds-amal
requested review from
haltman-at,
eggplantzzz,
cliffoo,
lsqproduction and
sukanyaparashar
cliffoo
approved these changes
Jul 23, 2022
| throw new Error(`Sandbox failed: source: ${source} does not exist`); | ||
| } | ||
|
|
||
| const tempDir = tmp.dirSync({ unsafeCleanup: true }); |
There was a problem hiding this comment.
This is cleaner than glob then fs.removeSync, nice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI jobs were randomly failing at
truffle unboxstep, so I added fixtures to avoid network calls. There's a bonus refactor to replace a promise callback with async/await.