This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
don't load Truffle's console contract into the console environment #5788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cds-amal
previously approved these changes
Dec 15, 2022
There was a problem hiding this comment.
I like it! Thanks, @eggplantzzz. I left a suggestion for the comment, which I don't think is a hack, but your call.
cds-amal
reviewed
Dec 15, 2022
cds-amal
reviewed
Dec 15, 2022
|
ah thanks, yes I inverted the logic trying to get this through quickly |
eggplantzzz
force-pushed
the
console-fix
branch
from
299d5b4
to
7f833fd
Compare
cds-amal
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops Truffle from loading its console contract into the console environment. Previously Truffle would load it into the console context (which users will not need to directly interact with in the repl) which would also cause the namespace error to be printed.