Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Bug fix: add debugGlobal default to config #5830

Merged
merged 1 commit into from Jan 13, 2023
Merged

Conversation

eggplantzzz
Copy link
Contributor

@eggplantzzz eggplantzzz commented Jan 11, 2023

Addresses #5828

PR description

There is a property that gets set on config (during testing) named debugGlobal. Currently Truffle relies on the yargs builder object to set this property which is jank. It is also causing problems where it doesn't get set when you miskey truffle test. There is an issue for this bug here. This PR adds a proper default for this value in @truffle/config.

Testing instructions

Run truffle tes on the command line. Verify that Truffle correctly runs the tests. If you currently try this on published Truffle, it will fail.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if documentation updates are required.

Breaking changes and new features

  • I have added any needed breaking-change and new-feature labels for the appropriate packages.

Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Weird how this bug manifested.

@lsqproduction
Copy link
Contributor

What's this debugGlobal?

@eggplantzzz
Copy link
Contributor Author

eggplantzzz commented Jan 12, 2023

It looks like it is the variable name used for setting break points when using the debugger. The default case is that it is called "debug". Someone can correct me, of course, if I'm wrong about that.

Copy link
Contributor

@dongmingh dongmingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this fix, truffle tes succeeds.

@haltman-at
Copy link
Contributor

It looks like it is the variable name used for setting break points when using the debugger. The default case is that it is called "debug". Someone can correct me, of course, if I'm wrong about that.

Well, they're not really break points; it lets you break into the debugger to debug particular transactions, but it doesn't let you set breakpoints inside of them, nor breakpoints outside of them for that matter.

@eggplantzzz eggplantzzz merged commit eeb1661 into develop Jan 13, 2023
@eggplantzzz eggplantzzz deleted the config-default branch January 13, 2023 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants