This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Bug fix: only edit state in txLog when we have an initial state #5919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
approved these changes
Feb 21, 2023
cds-amal
approved these changes
Feb 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use this utility with the debugger in light mode resulted in a crash. We tracked this down in the debugger, it crashed at this line. Apparently in light mode, this tx log tracking is not enabled and will make
initialStatenullwhich in turn will cause things to crash. This PR fixes this by only updating state when we receive a value forinitialState.